Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: check for missing mac_overrides #941

Merged
merged 2 commits into from
Sep 10, 2024
Merged

workflows: check for missing mac_overrides #941

merged 2 commits into from
Sep 10, 2024

Conversation

Noki
Copy link
Member

@Noki Noki commented Aug 17, 2024

I tried to make this run only on changed files, however I could not get this to work with github actions, it only worked locally for me.

The following issues exist and should be fixed at some point, however I think we can still just have this check and it will fail for not, but not affect the ability to still merge.

  • Host "gub37-hof-s" (model: "mikrotik_sxtsq-5-ac") in locations/gub37.yml is missing mac_override.
  • Host "hacrafu-fiocchi-core" (model: "dlink_covr-x1860-a1") in locations/hacrafu-fiocchi.yml is missing mac_override.
  • Host "hacrafu-gigli-core" (model: "dlink_covr-x1860-a1") in locations/hacrafu-gigli.yml is missing mac_override.
  • Host "hacrafu-girandole-core" (model: "dlink_covr-x1860-a1") in locations/hacrafu-girandole.yml is missing mac_override.
  • Host "k12-3v0s" (model: "dlink_covr-x1860-a1") in locations/k12-3v0s.yml is missing mac_override.
  • Host "k12-haus4-core" (model: "dlink_covr-x1860-a1") in locations/k12-haus4.yml is missing mac_override.
  • Host "k12-core" (model: "dlink_covr-x1860-a1") in locations/k12.yml is missing mac_override.
  • Host "k12-2h1s" (model: "dlink_covr-x1860-a1") in locations/k12.yml is missing mac_override.
  • Host "zwingli-nord-nf-5ghz" (model: "mikrotik_sxtsq-5-ac") in locations/zwingli.yml is missing mac_override.

@Noki Noki marked this pull request as draft August 18, 2024 07:12
@Noki Noki marked this pull request as ready for review August 18, 2024 10:15
@FFHener
Copy link
Contributor

FFHener commented Aug 20, 2024

we can still just have this check and it will fail for not, but not affect the ability to still merge.

I like this approach in general, as this check feels more optional.

@Noki Noki force-pushed the mac_overrides branch 9 times, most recently from 9ce0532 to 7d1157c Compare August 30, 2024 10:30
@Noki
Copy link
Member Author

Noki commented Aug 30, 2024

I think this is PR is ready to be merged now. The checks fails unless mac_overrides are properly set for all devices with a require flag, however since this is not a required check a PR failing this check can still be merged.

@pktpls
Copy link
Contributor

pktpls commented Sep 10, 2024

Looks good, very useful to include the command for each device 👍

@pktpls pktpls merged commit 86ff9f6 into main Sep 10, 2024
10 of 12 checks passed
@pktpls pktpls deleted the mac_overrides branch September 10, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants