This repository has been archived by the owner on May 17, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
Refactor compiler #486
Merged
Refactor compiler #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtsao
force-pushed
the
next
branch
4 times, most recently
from
August 28, 2018 16:43
9940009
to
2952e4a
Compare
rtsao
requested review from
ganemone,
lhorie and
KevinGrandon
and removed request for
ganemone and
lhorie
August 30, 2018 23:32
KevinGrandon
previously approved these changes
Aug 31, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to stamp this for now, but might be nice to run through some of this with you later today or next week.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Webpack compilation/loader communication
The old pattern relied on shared state via singletons which was far from ideal. This has been replaced with usage of loader context (and plugins that provide/consume this context). Shared state (between compilations and loaders as well as between sibling compilations) is now instantiated, passed, and mutated in a much more explicit manner.
Resolves #7
Resolves #8
Resolves #9
Resolves #15
Resolves #47
Lays the groundwork for #393 #426 fusionjs/rfcs#7 fusionjs/rfcs#10