-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(embassy)!: extract arch
modules as crates
#392
refactor(embassy)!: extract arch
modules as crates
#392
Conversation
a412d4b
to
1b1405f
Compare
7619fc9
to
dfcd104
Compare
dfcd104
to
c3e78ea
Compare
Please squash & rebase. Looks fine already, I'll give it a final review by tomorrow. |
dfaca71
to
552dd4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say this is almost good to go.
Please do the rename riot-rs-shared-types
-> riot-rs-embassy-common
, and move the now duplicated wifi config there.
2139964
to
df1e30e
Compare
df1e30e
to
53bb828
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
That mode has been broken during future-proof-iot#392
That mode has been broken during future-proof-iot#392
That mode has been broken during future-proof-iot#392
That mode has been broken during future-proof-iot#392
Description
This PR extracts the
arch
modules (the manufacturer-specific modules previously found inriot-rs-embassy
) as separate, manufacturer-specific crates. A major benefit of this is allowing to generate user-visible documentation for these crates, which was not possible before because (a) only onearch
module could be enabled at a time and (b) it was not possible to enable any of them for documentation, because of them being manufacturer-specific.Extracting these modules as separate crates has required to:
riot-rs-shared-types
) to break cyclic dependencies between crates/types: this new crate is depended upon by every manufacturer-specific crate.riot-rs-shared-types
crate to accommodate manufacturer-specific variants in enums, by introducing simple generics on them.Issues/PRs references
Depends on #391
Depends on #394
Open Questions
Testing
The following have been successfully tested in hardware (on dfaca71):
example/gpio
on nRF52840-DK, nRF5340-DK, ESP32-C6, RP2040, ST-NUCLEO-WB55RGexample/embassy-http-server
TODO
Future work
Change checklist