Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xtensa): add support for esp32s3 with xtensa arch #399

Merged
merged 7 commits into from
Sep 27, 2024

Conversation

elenaf9
Copy link
Collaborator

@elenaf9 elenaf9 commented Sep 6, 2024

Description

  • Add support for xtensa arch in riot-rs-threads
  • Add support for esp32s3 chip in riot-rs-embassy (cc @ROMemories given that these are minimal changes, I don't think there will be many merge conflicts with refactor(embassy)!: extract arch modules as crates #392. I'll rebase once that PR is in)
  • Add espressif-esp32-s3-wroom-1 board
  • Adapt the laze-project.yml based on prio work from @kaspar030.

Testing

Rust on xtensa requires the installation of the esp toolchain and setting up the environment correctly. See the Rust on ESP Book. It can then be run as usual with

laze build -C examples/threading -b espressif-esp32-s3-wroom-1 run

Issues/PRs references

Fixes #359.

Open TODOs

There are still linker issues that have to be fixed. Right now I simply worked around them by commenting out the conflicting parts, and somehow it worked. See self-review.

Change checklist

  • I have cleaned up my commit history and squashed fixup commits.
  • I have followed the Coding Conventions.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.

laze-project.yml Outdated Show resolved Hide resolved
laze-project.yml Outdated Show resolved Hide resolved
@kaspar030
Copy link
Collaborator

@elenaf9 do you mind rebasing this?

Copy link
Collaborator

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase (again), and squash. and probably, do a cargo update, I added a commit to our embasssy fork to use the old waker code, which the current xtensa compiler needs.

src/riot-rs-threads/src/arch/xtensa.rs Show resolved Hide resolved
@kaspar030
Copy link
Collaborator

I've added installing the xtensa toolchain for esp32s3 to CI, also building for the espressif-esp32-s3-wroom-1 board.

IMO this is good to go, apart from the CI (unrelated?) errors and the bench_sched_yield change.

@kaspar030 kaspar030 added this pull request to the merge queue Sep 27, 2024
Merged via the queue into future-proof-iot:main with commit 1753261 Sep 27, 2024
26 checks passed
@elenaf9 elenaf9 deleted the esp32s3 branch September 27, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch Architecture support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Xtensa support
3 participants