remove methods that are out of scope for DRS v1 #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might want to delete the compliance test completely now that we don't have Create methods, but this should at least get the script to run.
At this point, it's pretty clear we should rethink testing completely.
Since they don't make sense now that we only have a read-only API
|
See my comments on the corresponding #219. I'm merging this into develop so work on v0.1 can continue, in particular issues #229, #213 To address #206 I created a release branch based on the repo just as we did the rename from DOS->DRS. This includes more features that we can cherry pick in future releases. I created a release branch so we can continue work on develop as I figure out how best to merge into master and get that up to date. |
briandoconnor
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #219 -- it removes all the create/update/delete methods, the list methods, and support for content versioning. (Note that I had to disable the Travis tests, since they depended on content creation -- I filed #234 to track more cleanup there.)