-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing GA4GH service-info to DRS #310
base: develop
Are you sure you want to change the base?
Conversation
@susheel, per the CONTRIBUTING guidelines, we only submit PRs to release branches, not to master. (The main reason is to make sure the Travis CI checks get run, including rebuilding the docs, in each branch -- that way we can be sure the change doesn't break anything, and confirm that the documentation matches the intent.) |
@dglazer Done. I have rebased this PR to release/v1.0.1 |
@susheel , I'm not an expert on the HubFlow process described in Contributing.MD, but I think the key parts are a) name your feature branch according to the required naming convention, and b) set it up to merge into One benefit of that is triggering the Travis CI checks; there are other benefits around the release process that I'm less familiar with. |
Done. |
GA4GH service-info has just tagged their release v1.0.0 which now makes this PR valid to merge, barring any build and test errors. |
Reviving this thread as getting @susheel it would be great if you are still available to work on this PR. The spec was recently migrated from Swagger to OpenAPI, so now there are some merge conflicts. Do you have the bandwidth to update your branch? |
Resolves #309