Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 348 post passport #349

Closed
wants to merge 10 commits into from

Conversation

briandoconnor
Copy link
Contributor

See Issue #348

@dglazer
Copy link
Member

dglazer commented Apr 12, 2021

OpenAPI question -- do we need to duplicate the content of the POST and GET endpoints? It would be a lot easier to read (and to maintain) if we could share the duplicated part. The current docs show two identically named methods, which is confusing.

@briandoconnor
Copy link
Contributor Author

Bigger issue @dglazer is this is swagger 2.0... not OpenAPI which is what we should move towards as a project. I'd prefer to not invest a lot of time figuring out how to do this in the old swagger language and focus on cleaning it up in the move to OpenAPI 3

@dglazer
Copy link
Member

dglazer commented Apr 12, 2021

I agree we should move to OpenAPI 3 asap -- @jb-adams to make sure that's on the list.
I'm not sure that will help with this particular issue, but I agree it's not worth debugging in swagger syntax.

@jb-adams
Copy link
Member

Looks like #230 aims to migrate to OpenAPI 3. @jaeddy @uniqueg has there been any movement on this lately? I can take this branch if you have no bandwidth currently

@briandoconnor
Copy link
Contributor Author

@jb-adams , it would be fantastic to move the OpenAPI 3 work forward and coordinate that with @jaeddy as part of the trans GA4GH effort to have common doc build approaches across our repos.

@uniqueg
Copy link

uniqueg commented May 5, 2021

Thanks @jb-adams that would be appreciated. Very little bandwidth here in May and June, unfortunately.

@briandoconnor
Copy link
Contributor Author

I'm closing this PR in favor of #363 which uses OpenAPI 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants