add conditional requirement on MappableConcept (#99)

ga4gh · Nov 16, 2024 · 2f8a937 · 2f8a937
1 parent 0f315ae
commit 2f8a937
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 6 deletions.
diff --git a/examples/mappable-concept-gene.yaml b/examples/mappable-concept-gene.yaml
@@ -1,6 +1,5 @@
 id: HGNC:1101
 primaryCode: BRCA2
-label: BRCA2 DNA repair associated
 conceptType: Gene
 mappings:
 - coding: 

diff --git a/schema/gks-core/def/MappableConcept.rst b/schema/gks-core/def/MappableConcept.rst
@@ -42,7 +42,7 @@ Some MappableConcept attributes are inherited from :ref:`Element`.
    *  - label
       - 
       - string
-      - 1..1
+      - 0..1
       - A primary name for the concept.
    *  - primaryCode
       - 

diff --git a/schema/gks-core/gks-core-source.yaml b/schema/gks-core/gks-core-source.yaml
@@ -147,8 +147,11 @@ $defs:
         description: >-
           A list of mappings to concepts in terminologies or code systems. Each mapping should
           include a coding and a relation.
-    required:
-      - label
+    oneOf:
+      - required:
+          - label
+      - required:
+          - primaryCode
 
   ConceptMapping:
     type: object

diff --git a/schema/gks-core/json/MappableConcept b/schema/gks-core/json/MappableConcept
@@ -41,8 +41,18 @@
          "description": "A list of mappings to concepts in terminologies or code systems. Each mapping should include a coding and a relation."
       }
    },
-   "required": [
-      "label"
+   "oneOf": [
+      {
+         "required": [
+            "label"
+         ]
+      },
+      {
+         "required": [
+            "primaryCode"
+         ]
+      }
    ],
+   "required": [],
    "additionalProperties": false
 }
-Original file line number
+Diff line change
@@ Expand Up @@
        *  - label
           -
           - string
-          - 1..1
+          - 0..1
           - A primary name for the concept.
        *  - primaryCode
           -
@@ Expand Down @@