Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mappableConcept primaryCoding & iris #110

Merged
merged 1 commit into from
Mar 2, 2025
Merged

mappableConcept primaryCoding & iris #110

merged 1 commit into from
Mar 2, 2025

Conversation

larrybabb
Copy link
Contributor

Changes based on decisions made during VA-Spec 1.0 PRC preparations. See ga4gh/va-spec#264

Copy link
Contributor Author

@larrybabb larrybabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self approved for expediency

@larrybabb larrybabb merged commit bf922d1 into 1.x Mar 2, 2025
2 checks passed
@larrybabb larrybabb deleted the va-1.0-updates branch March 2, 2025 00:43
larrybabb added a commit that referenced this pull request Mar 2, 2025
snapshot-2025-02.3 id updates
should be identified as the primary code.
primaryCoding:
$ref: "#/$defs/Coding"
description: A primary coding for the concept.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larrybabb I feel like we could give some additional guidance about how to populate this attribute - either here or in the web docs.

In our discussions, I think we decided that this is used to hold "a code that is considered the primary representation of the concept, as defined or used in the data provider's system". Adding language like this could help implementers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants