Skip to content

Commit

Permalink
fix: add oneOf to StudyResult
Browse files Browse the repository at this point in the history
  • Loading branch information
korikuzma committed Feb 21, 2025
1 parent 268a527 commit bc524de
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
12 changes: 12 additions & 0 deletions schema/va-spec/base/json/StudyResult
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
"$id": "https://w3id.org/ga4gh/schema/va-spec/1.x/base/json/StudyResult",
"title": "StudyResult",
"maturity": "trial use",
"description": "A collection of data items from a single study that pertain to a particular subject or experimental unit in the study, along with optional provenance information describing how these data items were generated.",
"$comment": "Note that a 'dataItem' attribute, which would hold an array of data selected for inclusion in the StudyResult, is not included in this version of the StudyResult class. Profiles that extend this core class can define data type specific attributes to capture such information (e.g.'focusAlleleCount', 'focusAlleleFrequency', and 'locuslAlleleCount' attributes in a CohortAlleleFrequencyStudyResult profile). But technical limitations in our current profiling framework tooling forced us to omit a core 'dataItems attribute that these specialized attributes would conceptually extend.",
"oneOf": [
"/ga4gh/schema/va-spec/1.x/base/json/CohortAlleleFrequencyStudyResult",
"/ga4gh/schema/va-spec/1.x/base/json/ExperimentalVariantFunctionalImpactStudyResult"
]
}
3 changes: 3 additions & 0 deletions schema/va-spec/base/va-core-source.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,9 @@ $defs:
'focusAlleleFrequency', and 'locuslAlleleCount' attributes in a CohortAlleleFrequencyStudyResult profile).
But technical limitations in our current profiling framework tooling forced us to omit a core 'dataItems
attribute that these specialized attributes would conceptually extend.
oneOf:
- "/ga4gh/schema/va-spec/1.x/base/json/CohortAlleleFrequencyStudyResult"
- "/ga4gh/schema/va-spec/1.x/base/json/ExperimentalVariantFunctionalImpactStudyResult"
heritableProperties:
focus:
oneOf:
Expand Down

0 comments on commit bc524de

Please sign in to comment.