Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add oneOf to StudyResult #270

Draft
wants to merge 3 commits into
base: 1.x
Choose a base branch
from
Draft

fix: add oneOf to StudyResult #270

wants to merge 3 commits into from

Conversation

korikuzma
Copy link
Contributor

  • re-run make all

See this comment: #243 (comment)

@korikuzma korikuzma self-assigned this Feb 19, 2025
Copy link
Contributor

@larrybabb larrybabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahwagner I think we need to rethink how we are going to do this. The limitation of not being able to reference abstract classes is not practical since we should be able to place any subclass of certain types like StudyResult as evidenceLine.items.

We will also eventually need to make sure Statement and EvidenceLine can be sub-classed as it seems to me that this is a preferred approach to some of the sub-typing we NEED to be able to do.

@korikuzma korikuzma marked this pull request as draft February 19, 2025 14:04
@ahwagner
Copy link
Member

@ahwagner I think we need to rethink how we are going to do this. The limitation of not being able to reference abstract classes is not practical since we should be able to place any subclass of certain types like StudyResult as evidenceLine.items.

We will also eventually need to make sure Statement and EvidenceLine can be sub-classed as it seems to me that this is a preferred approach to some of the sub-typing we NEED to be able to do.

@larrybabb sure, let's talk about these items at 4p today.

@korikuzma korikuzma changed the title fix: remove StudyResult from EvidenceLine.hasEvidenceItems fix: add oneOf to StudyResult Feb 21, 2025
Comment on lines +150 to +152
oneOf:
- "/ga4gh/schema/va-spec/1.x/base/json/CohortAlleleFrequencyStudyResult"
- "/ga4gh/schema/va-spec/1.x/base/json/ExperimentalVariantFunctionalImpactStudyResult"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants