-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add oneOf
to StudyResult
#270
base: 1.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahwagner I think we need to rethink how we are going to do this. The limitation of not being able to reference abstract classes is not practical since we should be able to place any subclass of certain types like StudyResult
as evidenceLine.items.
We will also eventually need to make sure Statement
and EvidenceLine
can be sub-classed as it seems to me that this is a preferred approach to some of the sub-typing we NEED to be able to do.
@larrybabb sure, let's talk about these items at 4p today. |
StudyResult
from EvidenceLine.hasEvidenceItems
oneOf
to StudyResult
oneOf: | ||
- "/ga4gh/schema/va-spec/1.x/base/json/CohortAlleleFrequencyStudyResult" | ||
- "/ga4gh/schema/va-spec/1.x/base/json/ExperimentalVariantFunctionalImpactStudyResult" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines added
See this comment: #243 (comment)