Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add coverage for dataproxy construction inputs #499

Merged
merged 5 commits into from
Feb 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ga4gh/vrs/dataproxy.py
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,8 @@ def create_dataproxy(uri: str | None = None) -> _DataProxy:
* seqrepo+http://localhost:5000/seqrepo
* seqrepo+https://somewhere:5000/seqrepo

:raise ValueError: if URI doesn't match recognized schemes, e.g. is missing provider
prefix (`"seqrepo+"`)
"""
uri = uri or os.environ.get("GA4GH_VRS_DATAPROXY_URI", None)

Expand Down
22 changes: 0 additions & 22 deletions tests/extras/test_dataproxy.py

This file was deleted.

67 changes: 67 additions & 0 deletions tests/test_dataproxy.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
import os
import re

import pytest

from ga4gh.vrs.dataproxy import create_dataproxy


@pytest.mark.parametrize("dp", ["rest_dataproxy", "dataproxy"])
@pytest.mark.vcr
def test_data_proxies(dp, request):
dataproxy = request.getfixturevalue(dp)
r = dataproxy.get_metadata("NM_000551.3")
assert r["length"] == 4560
assert "ga4gh:SQ.v_QTc1p-MUYdgrRv4LMT6ByXIOsdw3C_" in r["aliases"]

r = dataproxy.get_metadata("NC_000013.11")
assert r["length"] == 114364328
assert "ga4gh:SQ._0wi-qoDrvram155UmcSC-zA5ZK4fpLT" in r["aliases"]

seq = dataproxy.get_sequence("ga4gh:SQ.v_QTc1p-MUYdgrRv4LMT6ByXIOsdw3C_")
assert seq.startswith("CCTCGCCTCCGTTACAACGGCCTACGGTGCTGGAGGATCCTTCTGCGCAC")

seq = dataproxy.get_sequence(
"ga4gh:SQ.v_QTc1p-MUYdgrRv4LMT6ByXIOsdw3C_", start=0, end=50
)
assert seq == "CCTCGCCTCCGTTACAACGGCCTACGGTGCTGGAGGATCCTTCTGCGCAC"


def test_data_proxy_configs():
with pytest.raises(
ValueError,
match=re.escape(
"create_dataproxy scheme must include provider (e.g., `seqrepo+http:...`)"
),
):
create_dataproxy("file:///path/to/seqrepo/root")

with pytest.raises(
ValueError,
match=re.escape("SeqRepo URI scheme seqrepo+fake-scheme not implemented"),
):
create_dataproxy("seqrepo+fake-scheme://localhost:5000")

with pytest.raises(
ValueError, match="DataProxy provider fake-dataprovider not implemented"
):
create_dataproxy("fake-dataprovider+http://localhost:5000")

with pytest.raises(
ValueError,
match="No data proxy URI provided or found in GA4GH_VRS_DATAPROXY_URI",
):
create_dataproxy(None)

# check that fallback on env var works
os.environ["GA4GH_VRS_DATAPROXY_URI"] = "seqrepo+:tests/data/seqrepo/latest"
create_dataproxy(None)

# check that method arg takes precedence by passing an invalid arg
with pytest.raises(
ValueError,
match=re.escape(
"create_dataproxy scheme must include provider (e.g., `seqrepo+http:...`)"
),
):
create_dataproxy("file:///path/to/seqrepo/root")
Loading