Support for more italic style & TypeScript .ts / .tsx #5
Conversation
tobiastimm
changed the title
|
First of all thanks for this PR. This also closes #19 |
.gitignore
Outdated
| @@ -1,3 +1,4 @@ | |||
| node_modules | |||
| *.vsix | |||
| .DS_Store | |||
| test | |||
There was a problem hiding this comment.
Why is test added here? Was it needed for this PR?
There was a problem hiding this comment.
ah sry, yeah I needed some files for testing and forgot to remove it.
package.json
Outdated
| "dark", | ||
| "sublime" | ||
| ], | ||
| "keywords": ["theme", "minimal", "oceanic", "dark", "sublime"], |
There was a problem hiding this comment.
Also, I think package.json have been unnecessarily modified here, as code changes here are exactly same. Can you please confirm and revert this change?
There was a problem hiding this comment.
Yh my prettier setup in viscose changed it. I will revert this change
themes/Subliminal-color-theme.json
Outdated
| "keyword.control", | ||
| "modifier", | ||
| "this" | ||
| ], |
There was a problem hiding this comment.
I think this change needs to come as a separate PR with before & after screenshots for all of the scopes modified, as we need to check/review first if all the changes look ok or not. Thanks!
|
Before It is still not 100% optimal, but I'm completely new to vscode theming, maybe some other people have some ideas or improvements. |
|
I've removed the italic style on the punctuation. Was kinda annoying for me Before After |
- Splitted themes for more italic style - Preserved original theme
|
I will close this PR and create a new one, because I've reworked my fork quite a bit. |
Fixes #4