Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for more italic style & TypeScript .ts / .tsx #5

Closed
wants to merge 7 commits into from
Closed

Support for more italic style & TypeScript .ts / .tsx #5

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
95def7b
Support for more italic style
tobiastimm May 1, 2018
0491b56
.ts/.tsx support
tobiastimm May 4, 2018
040915c
Changed TypeScript colors
tobiastimm May 4, 2018
9d3f502
Set from to normal style
tobiastimm May 4, 2018
25865fc
Code-Review fixes
tobiastimm May 5, 2018
653266d
Removed italic style of punctuation
tobiastimm May 7, 2018
94b8c31
- Added demo files,
tobiastimm May 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions themes/Subliminal-color-theme.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,13 +246,31 @@
}
},
{
"scope": "source.js entity.other.attribute-name.js",
"settings": {
"fontStyle": "italic"
}
},
{
"scope": "text.html.basic entity.other.attribute-name.html",
"name": "Italic font style",
"scope": [
"entity.name.function.ts",
"entity.name.function.tsx",
"support.type.primitive",
"entity.other.attribute-name",
"entity.name.tag.custom",
"source.js.jsx keyword.control.flow.js",
"support.type.property.css",
"support.function.basic_functions",
"variable.assignment.coffee",
"support.function.basic_functions",
"keyword.operator.type.annotation",
"punctuation.section.embedded",
"assignment.coffee",
"entity.name.type.ts",
"italic",
"quote",
"type .function",
"type.function",
"storage.type.class",
"keyword.control",
"modifier",
"this"
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change needs to come as a separate PR with before & after screenshots for all of the scopes modified, as we need to check/review first if all the changes look ok or not. Thanks!

"settings": {
"fontStyle": "italic"
}
Expand Down