-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add History Multiview activity+panel, add "Show Recent" mode to multiview #17251
Add History Multiview activity+panel, add "Show Recent" mode to multiview #17251
Conversation
6daed04
to
6f8079e
Compare
298acc5
to
c2c9470
Compare
6dcfa52
to
f08139b
Compare
f08139b
to
35c7edd
Compare
This is a huge improvement, I like it a lot. I am skeptical that merging this with the regular histories activity will be an improvement ? |
A separate Histories activity side panelhistories_activity_panel_separate.mp4This is separate from the This can be tested here: |
1013b61
to
47bf7fb
Compare
A Singular Histories activity and side panelsingular_histories_activity.mp4This is an example of a singular This can be tested here: |
879c218
to
0445647
Compare
Split Activity Buttons (panel and route both in one activity)split_activity_button.mp4This way the user can quickly open the History Grid or open the Histories panel Implemented on top of https://github.com/ahmedhamidawan/galaxy/tree/histories_side_panel |
ba45b09
to
9d28591
Compare
This adds the option of showing 4 latest histories in Multiview, instead of always tracking pinned histories. Once the user decides to track pinned histories, we do so, until the user "resets" it to recent histories mode. Also organized the multiple histories in Multiview to show up evenly, with the `HistoryDetails` taking up a fixed space at the top.
Refactored `SelectorModal` to use the new history scroll list in it. Also, prevented `Upload` activity in activity bar from toggling out the current sidepanel.
If no pinned histories, we are in "show recent mode" and the new history will be appended to the beginning of the view.
Alter the way the `ActivityBar` treats "panel activities"; i.e.: activities that have a sideBar associated, so that if the sidebar is active but the current route isn't `activity.to`, then keep sidebar active and just change route. Also, if `activity.to` is current route, always keep activity's `is-active` prop = true regardless of sidebar for the activity being active or not.
This adds an upper div to the `.history-picker` which can be clicked to create and pin a new history.
Also added `keydown` events for tab accessibility
Adjust classes to make all activity panels look uniform
This caused a jest to fail because we tried to access the `filtered` computed array before it was even initialized.
Co-authored-by: Alireza Heidari <[email protected]>
Co-authored-by: Alireza Heidari <[email protected]>
Also, use imported icons instead of string icons for `FontAwesomeIcon`s
dcc8a25
to
373c189
Compare
Failing Toolshed tests seem unrelated... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks! @ahmedhamidawan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Cool stuff!
Added a History Multiview activity and side panel, which can be used to select histories in Multiview.
This also adds the option of showing 4 latest histories in History multi view, instead of always tracking pinned histories. Once the user decides to track pinned histories, we do so, until the user "resets" it to recent histories mode.
Also organized the multiple histories in Multiview to show up evenly, with the
HistoryDetails
taking up a fixed space at the top.Fixes #17143
Closes #16001 (every item when mounted, is loaded here)
Screen.Recording.2024-01-16.at.6.31.27.PM.mov
A singular
Histories
activity and panel?This also opens up the potential of a singular
Histories
activity+side panel which - instead of changing route to the histories list (as the histories activity currently does) - toggles out a Histories side panel, and this panel contains:HistoryPanel
(and other AdditionalOptions) by defaultIdea for #17284 ?
How to test the changes?
(Select all options that apply)
License