Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add History Multiview activity+panel, add "Show Recent" mode to multiview #17251

Merged
merged 19 commits into from
Feb 22, 2024

Commits on Feb 20, 2024

  1. add show recent functionality to multiview, uniform multi history view

    This adds the option of showing 4 latest histories in Multiview,
    instead of always tracking pinned histories. Once the user decides
    to track pinned histories, we do so, until the user "resets" it to
    recent histories mode.
    
    Also organized the multiple histories in Multiview to show up evenly,
    with the `HistoryDetails` taking up a fixed space at the top.
    ahmedhamidawan committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    1e9c433 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    331b948 View commit details
    Browse the repository at this point in the history
  3. use HistoryScrollList in SelectorModal

    Refactored `SelectorModal` to use the new history scroll list in it.
    Also, prevented `Upload` activity in activity bar from toggling out the current sidepanel.
    ahmedhamidawan committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    531608f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0e4cc29 View commit details
    Browse the repository at this point in the history
  5. only pin new history in multiview if we already have pinned histories

    If no pinned histories, we are in "show recent mode" and the new history will be appended to the beginning of the view.
    ahmedhamidawan committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    7568722 View commit details
    Browse the repository at this point in the history
  6. for "panel activities" only toggle sideBar if route !== activity.to

    Alter the way the `ActivityBar` treats "panel activities";
    i.e.: activities that have a sideBar associated,
    so that if the sidebar is active but the current route isn't `activity.to`, then keep sidebar active and
    just change route.
    
    Also, if `activity.to` is current route, always keep activity's `is-active` prop = true regardless of sidebar for the activity being active or not.
    ahmedhamidawan committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    c3649de View commit details
    Browse the repository at this point in the history
  7. add create and pin option to MultipleViewList as well

    This adds an upper div to the `.history-picker` which can be clicked to create and pin a new history.
    ahmedhamidawan committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    6b2a52f View commit details
    Browse the repository at this point in the history
  8. add tabindex to history switch area in MultipleViewList

    Also added `keydown` events for tab accessibility
    ahmedhamidawan committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    52982db View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    43c28e8 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    21ee913 View commit details
    Browse the repository at this point in the history
  11. use ActivityPanel in MultiviewPanel

    Adjust classes to make all activity panels look uniform
    ahmedhamidawan committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    ab96348 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    717e6a9 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    2ceff58 View commit details
    Browse the repository at this point in the history
  14. remove immediate flag from isScrollable check

    This caused a jest to fail because we tried to access the `filtered` computed array before it was even initialized.
    ahmedhamidawan committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    33179ac View commit details
    Browse the repository at this point in the history
  15. Update client/src/components/Panels/MultiviewPanel.vue

    Co-authored-by: Alireza Heidari <[email protected]>
    ahmedhamidawan and itisAliRH committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    851f784 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    16274c6 View commit details
    Browse the repository at this point in the history
  17. fix see more/less bug

    ahmedhamidawan committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    59f43f6 View commit details
    Browse the repository at this point in the history
  18. refactor changes to use explicit bootstrap components etc

    Also, use imported icons instead of string icons for `FontAwesomeIcon`s
    root authored and ahmedhamidawan committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    373c189 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Configuration menu
    Copy the full SHA
    151aed5 View commit details
    Browse the repository at this point in the history