Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define simple models for job messages. #19688

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jmchilton
Copy link
Member

Implements #19676 - first step toward proper typing on the frontend and solving one more vue-tsc error.

A note about a refactoring and dependencies

I moved the Job schema definition into the API package so it can depend on galaxy-tool-util. For now - us defining models in both galaxy-schema and galaxy-tool-util will mean combined models need to be placed in a package that depends on them both. I think longer term we will need to separate all the galaxy-tool-util models out into their own package and have galaxy-schema depend on that. Maybe I'm wrong though and the right approach is just to place all the models into galaxy-schema and update galaxy-tool-util to depend on that - I just really want galaxy-tool-util to have minimal dependencies and it seems like there is so much unrelated to artifact parsing and execution in galaxy-schema.

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton force-pushed the job_message_typing branch 2 times, most recently from 11ad9bc to 18be504 Compare February 24, 2025 22:14
@jmchilton jmchilton mentioned this pull request Feb 25, 2025
2 tasks
@jmchilton jmchilton force-pushed the job_message_typing branch 5 times, most recently from df1bec7 to d184e19 Compare February 26, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant