Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diamond various fixes #4210

Merged
merged 2 commits into from
Nov 27, 2021
Merged

diamond various fixes #4210

merged 2 commits into from
Nov 27, 2021

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Nov 23, 2021 •
edited
Loading

  • fix test parameter name: comp-based-stat needs to be comp_based_stats
  • remove param name attribute where possible
  • add options missing from command line (salltitles and sallseqid were in the inputs but unused in the CLI)
  • fix --unal (reports unaligned queries in fmt 6)
  • add --al and modify --un for reporting (un)aligned query sequences

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

@bernt-matthias
diamond fix test parameter name
fe59bc3 
comp-based-stat needs to be comp_based_stats

also remove param name atribute where possible
@bernt-matthias bernt-matthias mentioned this pull request Nov 23, 2021
Open
67 tasks
@bernt-matthias

This comment has been minimized.

Sign in to view
@bernt-matthias bernt-matthias marked this pull request as draft November 25, 2021 11:28
@bernt-matthias bernt-matthias mentioned this pull request Nov 25, 2021
Open
59 tasks
@bernt-matthias
add options missing from command line
4a2a8fd 
- salltitles and sallseqid were in the inputs but unused in the CLI
- fix --unal (reports unaligned queries in fmt 6)
- add --al and modify --un for reporting (un)aligned query sequences
@bernt-matthias bernt-matthias marked this pull request as ready for review November 25, 2021 16:30
@bernt-matthias bernt-matthias changed the title diamond fix test parameter name diamond various fixes Nov 25, 2021
@bgruening bgruening merged commit 828c844 into galaxyproject:master Nov 27, 2021
@bernt-matthias bernt-matthias deleted the topic/diamond-test-param-name branch March 14, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernt-matthias @bgruening