Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meme*: add non_commercial_use to command #4241

Merged

Conversation

bernt-matthias
Copy link
Contributor

I guess the validator should be sufficient, but maybe having this
additional if block can't hurt

will make the linter happy for galaxyproject/galaxy#12724
alternatively we could extend the linter such that
parameters that do not appear on the command line
bu have a (expression) validator? are OK??

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

I guess the validator should be sufficient, but maybe having this
additional if block can't hurt

will make the linter happy for galaxyproject/galaxy#12724
alternatively we could extend the linter such that
parameters that do not appear on the command line
bu have a (expression) validator? are OK??
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok. Its crucial for commercial partners that this is on place.

@bgruening bgruening merged commit 8c1eac5 into galaxyproject:master Nov 27, 2021
<token name="@CHECK_NON_COMMERCIAL_USE@"><![CDATA[
#if not $non_commercial_use
>&2 echo "this tool is only available for non commercial use";
exit 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a ; at the end of the line here and below?

bernt-matthias added a commit to bernt-matthias/tools-iuc that referenced this pull request Nov 27, 2021
@bernt-matthias bernt-matthias mentioned this pull request Nov 27, 2021
5 tasks
@bernt-matthias bernt-matthias deleted the topic/meme-unused-param branch March 14, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants