-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
picard improvements (sort order) #5103
Draft
bernt-matthias
wants to merge
12
commits into
galaxyproject:main
Choose a base branch
from
bernt-matthias:topic/picard-so
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
picard improvements (sort order) #5103
bernt-matthias
wants to merge
12
commits into
galaxyproject:main
from
bernt-matthias:topic/picard-so
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because deprepated (for ASSUME_SORT_ORDER) and the info is in the metadata.
and use matadata
67 tasks
bernt-matthias
force-pushed
the
topic/picard-so
branch
from
January 27, 2023 15:39
b28f934
to
63b995c
Compare
- remove for FixMateInformation - fix for MergeSamFiles
for touched tools
we have now query sorted bam .. so use it guess we do not need sam output
in particular if sam was supported anyway
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASSUME_SORTED
because deprepated (for ASSUME_SORT_ORDER) and the info is in the metadataASSUME_SORTED
and use metadataIn both cases we might also think about to omit
ASSUME_SORTED="false"
orASSUME_SORT_ORDER="unsorted"
, resp., because then picard should just use the info in the header.unsorted.bam
(ie all bam types) as input for most of the touched tools (except for the mark duplicates tools which seem to need coord or qname sorted bam) .. I guess there are more which could takeunsorted.bam
unsorted.bam
also for most of the other types (in particular ifsam
was supported)TODO:
Collect Alignment Summary Metrics writes a file containing summary alignment metrics
to the name of the underlying toolFOR CONTRIBUTOR: