Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picard improvements (sort order) #5103

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Jan 27, 2023

  • picard MarkDup*: remove ASSUME_SORTED because deprepated (for ASSUME_SORT_ORDER) and the info is in the metadata
  • remove ASSUME_SORTED and use metadata

In both cases we might also think about to omit ASSUME_SORTED="false" or ASSUME_SORT_ORDER="unsorted", resp., because then picard should just use the info in the header.

TODO:

  • remane Collect Alignment Summary Metrics writes a file containing summary alignment metrics to the name of the underlying tool

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

because deprepated (for ASSUME_SORT_ORDER) and the info is
in the metadata.
- remove for FixMateInformation
- fix for MergeSamFiles
for touched tools
we have now query sorted bam .. so use it

guess we do not need sam output
in particular if sam was supported anyway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Picard MarkDuplicates: OPTICAL_DUPLICATE_PIXEL_DISTANCE
1 participant