Add default resource params and slurm destination

[nuwang]

closes: galaxyproject/total-perspective-vortex#114

[cat-bro]

if default inherits tbvdb_default, what do this do that is different?

[nuwang]

The idea was to preserve backward compatibility, but I think that this may end up just creating an infinite loop. We probably want this these changes to spread to all destinations anyway, so I'll change this back.

[nuwang]

Fixed.

[cat-bro]

This looks good. The way it is structured, would it be an opt-out rather than opt-in setup?

[cat-bro]

I'm wondering if these variable names are too generic. 'time' in particular could collide with python's time library

[nuwang]

That's a good point. I've renamed time for now, but perhaps we could just prefix everything with slurm_ instead?

[bgruening]

I like the prefixing idea.

[nuwang]

Suggested change

	context:
	time: ''
	partition: ''
	account: ''
	params:
	native_specification: --nodes=1 --ntasks={cores} --mem={round(mem*1024)} {'--time='
	+ time if time else ''} {'--gres=gres:gpu:' + str(gpus) if gpus else ''} {'--partition='
	+ partition if partition else ''} {'--account=' + account if account else
	''}
	context:
	walltime: ''
	partition: ''
	account: ''
	params:
	native_specification: --nodes=1 --ntasks={cores} --mem={round(mem*1024)} {'--time='
	+ walltime if walltime else ''} {'--gres=gres:gpu:' + str(gpus) if gpus else ''} {'--partition='
	+ partition if partition else ''} {'--account=' + account if account else
	''}

[nuwang]

That's a good point. I've renamed time for now, but perhaps we could just prefix everything with slurm_ instead?

[cat-bro]

given that this is multiline, it could be clearer to use one argument per line
--nodes=1
--ntasks={cores}
etc

[nuwang]

This was because oftpv format. I've tried an alternative formatting that at least preserves everything in one, very lengthy line. Setting the block chomping indicator to strip newlines also gets reformatted, so the only options appear to be either a single lengthy line or multiple lines broken up as above.

[cat-bro]

Fair enough. I hadn't thought about tpv format. This looks good as is

[bgruening]

I'm not familiar with SLURM, to me it looks good. Thanks @nuwang