Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sars anvil tutorial #4250

Merged
merged 36 commits into from
Jul 10, 2023
Merged

Conversation

nakucher
Copy link
Contributor

@nakucher nakucher commented Jul 2, 2023

Excited to contribute the GDSCN SARS with Galaxy in AnVIL (https://jhudatascience.org/GDSCN_Book_SARS_Galaxy_on_AnVIL/index.html) tutorial to the GTN! This is my first tutorial so please feel free to help me fix anything that needs fixing.

@nakucher nakucher marked this pull request as ready for review July 2, 2023 22:00
@nakucher nakucher requested a review from a team as a code owner July 2, 2023 22:00
Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nakucher, welcome to the GTN! Great to see this. I've made some comments, and there are some more comments from the review bot that you'll find in the 'files' tab.

@nakucher
Copy link
Contributor Author

nakucher commented Jul 4, 2023

@hexylena I am getting this error in the Accessibility Linting regarding the time_estimation tutorial.md metadata (this also happened as I tested building the site with gitpod). I've tried copy/pasting directly from other tutorials to match the formatting with no luck. Any ideas?

Liquid Exception: undefined method []' for nil:NilClass in /home/runner/work/training-material/training-material/_layouts/tutorial_hands_on.html bundler: failed to load command: jekyll (/home/runner/work/training-material/training-material/vendor/bundle/ruby/3.0.0/bin/jekyll) /home/runner/work/training-material/training-material/_plugins/jekyll-duration.rb:34:in duration_to_human': undefined method `[]' for nil:NilClass (NoMethodError)

@nakucher
Copy link
Contributor Author

@hexylena all checks passed! would it be possible to merge?

Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments :)

avatar: https://www.genome.gov/themes/custom/nhgri/assets/global/NHGRI-logo.svg
url: https://www.genome.gov/
funder: true
funding_id: 75N92022P00232
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking for the funding IDs I find links like
https://reporter.nih.gov/search/15E8C00F4784C1D77598B8961CAA4A01A2FFCEB861BF/projects?shared=true&legacy=1&sl=15E8C00F4784C1D77598B8961CAA4A01A2FFCEB861BF

but that seems to be broken, hmm. Normally we link out to those pages but here I'm not sure it's possible which is unfortunate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yes it looks like RePORTER has been down for a little while :(

- Become familiar with reference genomes and alignments
- Explore the file structure of genomic data and quality scoring

<a href="http://www.youtube.com/watch?feature=player_embedded&v=MEZP_AzlLyg" target="https://youtu.be/MEZP_AzlLyg"><img src="http://img.youtube.com/vi/MEZP_AzlLyg/0.jpg" alt="Video thumbnail image for the Alignments background video." width="240" height="180" border="10" /></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe someday, if y'all keep working on this, it could be interesting to integrate these slides directly into the GTN. Then you could take advantage of our automated videos to keep videos up to date. e.g. https://training.galaxyproject.org/training-material/videos/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree! I'd love to do that in the near future.

>
>Using this formula, we can calculate that a quality score of 40 means only 0.00010 probability of an error!
>
> Learn more from the [Quality Control Tutorial FAQs](https://training.galaxyproject.org/training-material/topics/sequence-analysis/tutorials/quality-control/faqs/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have triggered an alert but somehow it avoided it. Need to investigate that at some later date.

@hexylena
Copy link
Member

Ok good it's failing now 😈 (sorry, but it should've been detecting the 'bad' links!)

@hexylena hexylena merged commit 5df6976 into galaxyproject:main Jul 10, 2023
2 of 3 checks passed
@nakucher nakucher deleted the add-sars-anvil-tutorial branch July 10, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants