-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenMS 3.1 #697
Merged
Merged
OpenMS 3.1 #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernt-matthias
force-pushed
the
openms2.9
branch
from
October 26, 2023 12:53
c630ad5
to
b02f4f8
Compare
bernt-matthias
force-pushed
the
openms2.9
branch
from
April 8, 2024 13:41
6391892
to
f59ede2
Compare
MSFragger contained a huge disclaimer :(
full message is: ``` Note: This message can also be triggered if you run out of space in your tmp directory or (32bit OMSSA only) OMSSA ran out of RAM because chunking was not used (that's the default) or 'chunk_size' was too large (>30k). Look above! ```
full message in stderr is: ``` Process '/gpfs1/data/galaxy_server/galaxy/database/dependencies/_conda/envs/mulled-v1-4ada2d9266641ecd767c7de738261cde57c65095a0fa06c286e3bc2f08b0cd57/bin/comet' crashed hard (segfault-like). Please check the log. ```
save space when cloning OpenMS
Adapter has been removed
and add test for xsd use in XMLValidator
and remove some code that was needed for tools that are now deprecated
needs login and is therefore difficult to test effort to implement tests would be useless since it will be dropped in next release anyway
won't run at the moment
now provided by OMS
blacklist MaRaClusterAdapter
Linter errors are all: |
bgruening
reviewed
Jun 13, 2024
bgruening
reviewed
Jun 13, 2024
bgruening
reviewed
Jun 13, 2024
bgruening
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing scary in here, added 3 small comments, but from my side this is good. Very cool, thanks!
to new aux file locations and remove some unneeded code
otherwise it won't be deployed
Ready :) |
🥳🥳🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For preparation .. collecting fixes :)
gxy2oms
3.1
expect_num_outputs
FLASHDecov
-out_spec FLASHDeconv_1_spec1.csv FLASHDeconv_1_spec2.csv FLASHDeconv_1_spec3.csv
(and analogously for