Increase default JVM stack size for PepQuery2 #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. This helps address stack overflows caused by recursively searching proteins for matching peptides.
reid-wagner
force-pushed
the
pepquery2_stack_increase
branch
from
96e05c3
to
9ccb781
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "non enzyme" digestion option results in a much larger search space and deeper recursion within PepQuery2, which can result in a stack overflow. This PR sets the JVM per-thread stack size to 2048KB. The default on Linux x86_64 is 1024KB.
A small typo in the format attribute for input files is corrected as well.