Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boolean to select bugs in msconvert #755

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/msconvert/msconvert.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<tool id="msconvert" name="msconvert" version="@VERSION@.3">
<tool id="msconvert" name="msconvert" version="@VERSION@.4">
<description>Convert and/or filter mass spectrometry files</description>
<macros>
<import>msconvert_macros.xml</import>
Expand Down
12 changes: 6 additions & 6 deletions tools/msconvert/msconvert_macros.xml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
#set inputmask = "'"+$basename+"'"
#end if

#if $data_processing.precursor_refinement.use_mzrefinement
#if $data_processing.precursor_refinement.use_mzrefinement == "true"
#set input_ident_name = ".".join((os.path.splitext($basename)[0], $data_processing.precursor_refinement.input_ident.ext))
#set output_refinement_name = os.path.splitext($basename)[0] + '.mzRefinement.tsv'
ln -s '$data_processing.precursor_refinement.input_ident' '$input_ident_name' &&
Expand Down Expand Up @@ -65,7 +65,7 @@
--filter "scanSumming precursorTol=$general_options.scan_summing.precursorTol scanTimeTol=$general_options.scan_summing.scanTimeTol ionMobilityTol=$general_options.scan_summing.ionMobilityTol"
#end if

#if $general_options.multi_run_output.do_multi_run_output:
#if $general_options.multi_run_output.do_multi_run_output == "true":
#if len($general_options.multi_run_output.run_index_set) > 0
--runIndexSet "
#for $index in $general_options.multi_run_output.run_index_set
Expand All @@ -85,7 +85,7 @@
--filter "peakPicking $data_processing.peak_picking.pick_peaks_algorithm msLevel=$data_processing.peak_picking.pick_peaks_ms_levels"
#end if

#if $data_processing.precursor_refinement.use_mzrefinement
#if $data_processing.precursor_refinement.use_mzrefinement == "true"
--filter "mzRefiner $input_ident_name
msLevels=$data_processing.precursor_refinement.precursor_refinement_ms_levels
thresholdScore=$data_processing.precursor_refinement.thresholdScore
Expand Down Expand Up @@ -229,7 +229,7 @@
#end if
#end if

#if $data_processing.precursor_refinement.use_mzrefinement
#if $data_processing.precursor_refinement.use_mzrefinement == "true"
&& mv '$output_refinement_name' '$output_refinement';
#end if
]]>
Expand Down Expand Up @@ -560,10 +560,10 @@
</change_format>
</data>
<data format="tsv" name="output_refinement" label="${($input.name[:-4] if $input.name.endswith('.tar') else $input.name).rsplit('.',1)[0]}.mzRefinement.tsv">
<filter>data_processing['precursor_refinement']['use_mzrefinement'] == True</filter>
<filter>data_processing['precursor_refinement']['use_mzrefinement'] == "true"</filter>
</data>
<collection name="multi_run_output_list" type="list" label="${($input.name[:-4] if $input.name.endswith('.tar') else $input.name).rsplit('.',1)[0]}.${output_type} collection">
<filter>general_options['multi_run_output']['do_multi_run_output'] == True</filter>
<filter>general_options['multi_run_output']['do_multi_run_output'] == "true"</filter>
<discover_datasets pattern="__name_and_ext__" directory="outputs" />
</collection>
</outputs>
Expand Down
Loading