-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a regression in Test
#5553
fix a regression in Test
#5553
Conversation
After reporting a difference, reset the line length to the previous value not to the default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me. Would be good if @ChrisJefferson had another look, though.
Actually there is also PR #5549 which seems to be about the same issues, more or less, but a bit differently. (I asked @ChrisJefferson to review that, too, some time ago...). It would be good if you three (@ThomasBreuer @zickgraf @ChrisJefferson could figure out which way to go...) |
Thanks @fingolfin .
|
Thanks @zickgraf. |
Looks good to me, I'll just let the tests all cycle, then I'm happy to merge (or someone else can hit the button before me) |
After reporting a difference,
reset the line length to the previous value not to the default value.
resolves #5552