Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a regression in Test #5553

Merged
merged 2 commits into from
Jan 4, 2024
Merged

fix a regression in Test #5553

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b49bd69
fixed a regression in `Test`
ThomasBreuer Jan 3, 2024
32f7ba9
avoid the local variable `testsize`
ThomasBreuer Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions lib/test.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@
InstallGlobalFunction(RunTests, function(tests, inopts, fnam)
local opts, breakOnError, alwaysPrintTracebackOnError, inp, outp,
pos, cmp, times, ttime, nrlines, s, res, fres, t, f, i,
localbag, failures, testsize, size;
localbag, failures, startsize, size;
# don't enter break loop in case of error during test
opts := rec( breakOnError := false, alwaysPrintTracebackOnError:= false,
showProgress := "some", localdef := false );
Expand All @@ -182,9 +182,8 @@
od;

# now start the work
size := SizeScreen();
testsize := [opts.width, size[2]];
SizeScreen(testsize);
startsize := SizeScreen();
SizeScreen([opts.width, startsize[2]]);

# we collect outputs and add them to 'tests.cmp'
# also collect timings and add them to 'tests.times'
Expand Down Expand Up @@ -248,7 +247,8 @@
if opts.showProgress = "some" then
Print("\r \c\r"); # clear the line
fi;
SizeScreen(size);
size := SizeScreen();
SizeScreen(startsize);

Check warning on line 251 in lib/test.gi

View check run for this annotation

Codecov / codecov/patch

lib/test.gi#L250-L251 

Added lines #L250 - L251 were not covered by tests
if not opts.ignoreSTOP_TEST or
PositionSublist(tests.inp[i], "STOP_TEST") <> 1 then
failures := failures + 1;
Expand All @@ -257,7 +257,7 @@
# print output of STOP_TEST
Print(tests.cmp[i]);
fi;
SizeScreen(testsize);
SizeScreen(size);

Check warning on line 260 in lib/test.gi

View check run for this annotation

Codecov / codecov/patch

lib/test.gi#L260 

Added line #L260 was not covered by tests
fi;
od;
if opts.showProgress = "some" then
Expand All @@ -268,7 +268,7 @@
# reset
BreakOnError := breakOnError;
AlwaysPrintTracebackOnError:= alwaysPrintTracebackOnError;
SizeScreen(size);
SizeScreen(startsize);
return failures;
end);

Expand Down