Refactor coreset classes #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rg936672
force-pushed
the
feature/coreset-refactor
branch
from
759a336 to
361f797
Compare
Also includes a _ton_ of Pyright fixes to ensure that everything keeps working properly!
rg936672
force-pushed
the
feature/coreset-refactor
branch
from
361f797 to
4317db0
Compare
Also improves the MapReduce tests to test three cases - a Coresubset case, a PseudoCoreset that is a subset of the original points, and a PseudoCoreset that is unrelated to the original points.
rg936672
force-pushed
the
feature/coreset-refactor
branch
from
1a4f8a4 to
4e3b4a4
Compare
rg936672
force-pushed
the
feature/coreset-refactor
branch
from
4e3b4a4 to
84e2cfd
Compare
9 tasks
qh681248
requested changes
Feb 6, 2025
qh681248
approved these changes
Feb 6, 2025
This was referenced Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Description
Refactor
CoresetandCoresubset(Coreset)intoAbstractCoreset,PseudoCoreset(AbstractCoreset), andCoresubset(AbstractCoreset).Also splits out
.nodesinto.indicesand.points, and deprecates.coresetin favour of.points.How Has This Been Tested?
Existing tests pass as expected. Pyright passes as well. We no longer need Pyright ignores in
coreset.py(aside from in parts of the code that are deprecated).Does this PR introduce a breaking change?
Yes, but deprecated aliases are added, so old code should still work. See the additions to the
Deprecatedsection ofCHANGELOG.Checklist before requesting a review