Code

Refactor coreset classes#943

Code

Merged

qh681248 merged 18 commits intomaingchq/coreax:mainfrom feature/coreset-refactorgchq/coreax:feature/coreset-refactorCopy head branch name to clipboardFeb 6, 2025

+829-270

Commits

Commits on Feb 5, 2025

• refactor: PseudoCoreset, Coresubset now subclasses of AbstractCoreset

  Show description for 68df5ad
  rg936672

  committed
  68df5ad

  Copy full SHA for 68df5ad

• feat: add deprecated aliases of old Coreset properties

  rg936672

  committed
  1bc8f5b

  Copy full SHA for 1bc8f5b

• fix: test errors (but introduces new pyright issues)

  rg936672

  committed
  45bbe9c

  Copy full SHA for 45bbe9c

• fix: remaining pyright issues

  rg936672

  committed
  e28d17b

  Copy full SHA for e28d17b

• feat: restore original coreset behaviour (though deprecated)

  rg936672

  committed
  2bf9477

  Copy full SHA for 2bf9477

• docs: improve coreset build() docstrings

  rg936672

  committed
  0e8e5ed

  Copy full SHA for 0e8e5ed

• chore: update CHANGELOG.md

  rg936672

  committed
  5ad8c51

  Copy full SHA for 5ad8c51

• fix: incorrect use of indices instead of points

  rg936672

  committed
  c251270

  Copy full SHA for c251270

• chore: link PR in CHANGELOG.md

  rg936672

  committed
  b5a19df

  Copy full SHA for b5a19df

• fix: import override from typing_extensions, not typing

  rg936672

  committed
  827610d

  Copy full SHA for 827610d

• fix(docs): fix Sphinx complaints

  rg936672

  committed
  9257d1a

  Copy full SHA for 9257d1a

• fix: use Coresubset in test_map_reduce_analytic

  rg936672

  committed
  365c4ef

  Copy full SHA for 365c4ef

• chore: replace some further uses of .nodes with .indices

  rg936672

  committed
  a16b0c7

  Copy full SHA for a16b0c7

• feat: partially resolve outstanding TODOs

  rg936672

  committed
  4317db0

  Copy full SHA for 4317db0

• fix: MapReduce no longer uses .nodes

  Show description for ab1d85b
  rg936672

  committed
  ab1d85b

  Copy full SHA for ab1d85b

• fix: remaining uses of .coreset and .nodes

  rg936672

  committed
  4f5194d

  Copy full SHA for 4f5194d

• tests: rework test_coreset to hit max coverage

  rg936672

  committed
  84e2cfd

  Copy full SHA for 84e2cfd

Commits on Feb 6, 2025

• fix: outdated mention of "nodes"

  rg936672

  committed
  e8f19da

  Copy full SHA for e8f19da