refactor(tests): Spawn node for the tests #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename to replay_back_and_updating
Conflicts: .github/workflows/ci.yml
gshep
changed the title
mertwole
reviewed
Nov 8, 2024
Conflicts: gear-programs/erc20-relay/app/tests/gclient.rs
Conflicts: .github/workflows/ci.yml
Conflicts: .github/workflows/ci.yml
mertwole
requested changes
Nov 29, 2024
There was a problem hiding this comment.
Maybe move these .json and .zst files to a new folder like tests/data ?
| } | ||
|
|
||
| #[ignore] |
| async fn spin_up_node() -> (GClientRemoting, GearApi, CodeId, GasUnit) { | ||
| static LOCK: Mutex<(u32, Option<CodeId>)> = Mutex::const_new((0, None)); | ||
|
|
||
| async fn spin_up_node() -> (impl Remoting + Clone, GearApi, CodeId, GasUnit, [u8; 4]) { |
There was a problem hiding this comment.
Suggested change
| async fn spin_up_node() -> (impl Remoting + Clone, GearApi, CodeId, GasUnit, [u8; 4]) { | |
| async fn connect_to_node() -> (impl Remoting + Clone, GearApi, CodeId, GasUnit, [u8; 4]) { |
| api, | ||
| code_id, | ||
| gas_limit, | ||
| salt.to_le_bytes(), |
There was a problem hiding this comment.
Maybe just generate random [u8; 32] for salt? As I see it will simplify code a lot
There was a problem hiding this comment.
I'm afraid we will need the mutex anyway since the first transaction of transferring funds from Alice to the account should be sent beforehand.
|
|
||
| let bootstrap = beacon_client.get_bootstrap(&checkpoint_hex).await?; | ||
| println!("bootstrap slot = {}", bootstrap.header.slot); | ||
| async fn live_init_holesky() -> Result<()> { |
There was a problem hiding this comment.
I'd prefer to go without these tests as they're anyway intended to use only for manual testing. If you need them I think they can be moved to /tools (and don't expose endpoints, just read env vars)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #161
@gear-tech/dev