Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tests): Spawn node for the tests #195
base: main
Are you sure you want to change the base?
refactor(tests): Spawn node for the tests #195
Changes from all commits
c4ab458
af10b25
4b26be3
adb6497
092e30d
210d530
a0d14d2
92c9f8e
fcec78b
9fdd463
a96dc90
31d2f3b
985e329
ec89686
06ae5f8
b0cc0d6
e9cdc78
33e6de9
3f45e79
a43471a
5f72272
eb293bd
9b7ac37
9839a26
960eadd
c17b6b3
c595ec3
2d4ccfe
ed1cd56
1f96b06
e345530
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just generate random [u8; 32] for salt? As I see it will simplify code a lot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid we will need the mutex anyway since the first transaction of transferring funds from Alice to the account should be sent beforehand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, maybe not a lot but you will not need to pass
salt
everywhere aroundThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is used for calculating minimal gas required to send
MintTokens
request so shouldn't be run every time. Moreover it will be removed in the PR with historical proxy implementation