Update bundled PostgreSQL to 16.4 #7804
Conversation
| if ( | ||
| isinstance(value, pgast.StringConstant) | ||
| and isinstance(is_local, pgast.BooleanConstant) | ||
| ): | ||
| if ( | ||
| value.val == "view, foreign-table" | ||
| and not is_local.val | ||
| ): | ||
| return value |
There was a problem hiding this comment.
I'd prefer not to do this here, because we are not checking the name of the setting being set. But to check that, we need the full query, because it is of this form:
SELECT set_config(name, ..., ...) FROM pg_setting WHERE name = '...'I'll add a pre-resolving step that convert such SELECT set_configs into SET commands, which we do handle correctly.
There was a problem hiding this comment.
I've tried that in #7810, but it turns out that if we compile SELECT set_config into SET, we need to inject a result set and CommandComplete message, which is hard/complex to do.
So I might abandon that effort and fix your approach instead.
There was a problem hiding this comment.
We will not abandon that effort, but just put it off until some later time.
For now, this workaround is good enough. Let's hope no one will use "view, foreign-table" setting value anywhere...
Uses tag: REL_16_4. Also updates our allowlist for `set_config` calls to support change introduced in 16.4 in postgres/postgres@66e9444 --------- Co-authored-by: Aljaž Mur Eržen <[email protected]>
aljazerzen
added
backported-5.x
Uses tag: REL_16_4. Also updates our allowlist for
set_configcalls to support change introduced in 16.4 in postgres/postgres@66e9444