Precompile SELECT set_config to SET #7810
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optimistic PR that might not be reasonable to fully implement.
I've added a pre-compilation step that turns
SELECT set_config
intoSET
commands.The problem now is that
SELECT set_config
:CommandComplete('SET')
, but it should returnCommandComplete('')
(this can be solved easily),We don't have a framework for injecting result tuples for SET commands that would work in general (for frontend-only actions and the normal ones). So I'm not sure if I should continue here.
The pro is that we would then support all basic
set_config
usages (top-level, without complicated SELECT clauses).The cons is that is needed only now, for solving #7804, where we need to just ignore a pg setting.