For #1199

[mugitty]

Note, this PR is associated with geneontology/go-site#2207

[dustine32]

@mugitty Change here is to rsync a aggregate-rule-violation-report.md file but where is this file generated? I don't see the command to generate in the Jenkinsfile. Does this line need to be updated too?

pipeline/Jenkinsfile

Line 762 in 995bd71

sh 'python3 ./scripts/combined_assigned_by.py -v --input ./combined.report.json --output ./assigned-by-combined-report.json'

[mugitty]

aggregate-rule-violation-report.md is an additional file that is generated by combined_assigned_by.py

[dustine32]

@mugitty Oh I see. Filename aggregate-rule-violation-report.md is hard-coded in combined_assigned_by.py.

This works but it might be nicer to parameterize that new output filename so that it's explicitly mentioned in the Jenkinsfile. I'll let @kltm decide whether that's really required.

[kltm]

When is the file going to start being produced and how? I want to make sure there is no lag so that rsync does not/cannot fail here. Ideally, the file would be produced and in the branches before the move itself was updated.

[mugitty]

@kltm , It is already being produced in https://build.geneontology.org/job/geneontology/job/pipeline/job/issue-go-site-2093-metadata/
geneontology/go-site#2207 (comment) has to go in first.

[kltm]

@mugitty it's not being produced on master, snapshot, or release, which are the ones I care about here. A mismatch would cause pipeline failure.

[mugitty]

@kltm , I will update on master

[kltm]

@mugitty To clarify, the go-site merge needs to happen before the pipeline merge.