Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing: Allow implementing other search routes than /search in other router services #850

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Apr 10, 2024

Description

This PR introduces uses getSearchRoute() instead of ROUTER_ROUTE_SEARCH within the router.facade to allow implementing other search routes than /search in other router services.

Note: Needs to remove ROUTER_ROUTE_HOME from the datahub-router.service to work (which is not part of the path due to a redirect).

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

to allow implementing other search routes than /search in other router services
Copy link
Contributor

Affected libs: feature-router,
Affected apps: datahub, metadata-editor, demo,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 86.602% (+0.6%) from 86.038%
when pulling 593b84e on search-route
into 4fbb164 on main.

Copy link
Contributor

📷 Screenshots are here!

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, that had gone under the radar, thanks :)

@@ -76,6 +76,6 @@ export class DatahubRouterService {
}

getSearchRoute(): string {
return `${ROUTER_ROUTE_HOME}/${ROUTER_ROUTE_SEARCH}`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite curious that this always worked

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkohr
Copy link
Collaborator Author

tkohr commented Apr 12, 2024

Oups I also forgot about it and missed the notification today. I think there is still an issue, when looking at the e2e tests. I'll take a look when coming back from holidays.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants