-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routing: Allow implementing other search routes than /search in other router services #850
base: main
Are you sure you want to change the base?
Conversation
to allow implementing other search routes than /search in other router services
Affected libs:
|
📷 Screenshots are here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, that had gone under the radar, thanks :)
@@ -76,6 +76,6 @@ export class DatahubRouterService { | |||
} | |||
|
|||
getSearchRoute(): string { | |||
return `${ROUTER_ROUTE_HOME}/${ROUTER_ROUTE_SEARCH}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's quite curious that this always worked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, maybe due to the redirect in lines https://github.com/geonetwork/geonetwork-ui/pull/850/files#diff-18147f3d9fd25936e42e709dea85cb97a42c69b44e19d92cde9d43f409ad6baaR30-R34 above...
Oups I also forgot about it and missed the notification today. I think there is still an issue, when looking at the e2e tests. I'll take a look when coming back from holidays. |
|
Description
This PR introduces uses
getSearchRoute()
instead ofROUTER_ROUTE_SEARCH
within therouter.facade
to allow implementing other search routes than/search
in other router services.Note: Needs to remove
ROUTER_ROUTE_HOME
from thedatahub-router.service
to work (which is not part of the path due to a redirect).Quality Assurance Checklist
breaking change
labelbackport <release branch>
label