Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making Rabbitmq optional for gateway - deactivated by default #62

Merged

Conversation

marwanehcine
Copy link
Contributor

On this PR, we set global parameter for activate/deactivate rabbitmq dependency on gateway

@marwanehcine marwanehcine force-pushed the make_rabbitmq_optional_for_gateway branch 4 times, most recently from a9398f1 to be35686 Compare September 29, 2023 00:27
@pmauduit
Copy link
Member

This PR will be superseded by #63 with this commit in particular: 18ab575

@marwanehcine marwanehcine force-pushed the make_rabbitmq_optional_for_gateway branch 3 times, most recently from 73ad10e to 50e184a Compare October 23, 2023 22:22
@marwanehcine
Copy link
Contributor Author

marwanehcine commented Oct 23, 2023

@pmauduit This PR will be superseded by #63 with this commit in particular: 18ab575

I have updated PR to make rabbitMQ disabled by default. We can merge and rebase for 63 later I think.
Thanks,

@emmdurin
Copy link
Contributor

I would prefer to merge this one

Yes, this situation is causing problems to some users, so we merge it now. We can of course rework it in #63 as wished.

@emmdurin emmdurin force-pushed the make_rabbitmq_optional_for_gateway branch from 50e184a to 6bd2da2 Compare October 24, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants