fix: button usage for links #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Button tags in forms submit the form. This means clicking the "Buy Bitcoin" link did not open the link but actually submit the form. According to the HTML spec a button tag must also not be nested into a hyperlink.
rolznz
approved these changes
Jul 27, 2024
|
there are some more buttons like this that we probably also should fix and try to have valid HTML. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Button tags in forms submit the form.
This means clicking the "Buy Bitcoin" link did not open the link but actually submit the form. According to the HTML spec a button tag must also not be nested into a hyperlink.
This PR removes those links from the form and uses hyperlinks with button styles (instead of a button tag)
note: I have no idea about those react elements/buttons