Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: button usage for links #355

Merged
merged 5 commits into from
Jul 27, 2024
Merged

fix: button usage for links #355

merged 5 commits into from
Jul 27, 2024

Commits on Jul 26, 2024

  1. fix: button usage for links 

    Button tags in forms submit the form.
This means clicking the "Buy Bitcoin" link did not open the link but actually submit the form.
According to the HTML spec a button tag must also not be nested into a hyperlink.
    @bumi
    bumi committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    c05f7cc View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. fix: new button component linter errors

    @rolznz
    rolznz committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    b5e7590 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into fix-link-button-usage

    @rolznz
    rolznz committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    d55392f View commit details
    Browse the repository at this point in the history

  3. fix: prettier error

    @rolznz
    rolznz committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    19a0c85 View commit details
    Browse the repository at this point in the history

  4. fix: tsc error

    @rolznz
    rolznz committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    f9eec24 View commit details
    Browse the repository at this point in the history