Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init MLflow support #2

Merged
merged 38 commits into from
Jun 20, 2023
Merged

Init MLflow support #2

merged 38 commits into from
Jun 20, 2023

Conversation

mwiewior
Copy link
Contributor

No description provided.

)

def _generate_mlflow_root_task_sql(self):
return """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-use self.TASK_TEMPLATE?

sql_statements = [self._generate_root_task_sql()]
sql_statements = [
self._generate_root_task_sql(),
self._generate_root_task_suspend_sql(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be immediately execute suspend after execute? Will it work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not ? For a brand new pipeline it is always suspended - so does not take any effect - for a replaced one it should just change the state ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe it would make sense to always drop a whole pipeline and then recreate it from scratch - it would then fix #3 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be, let's discuss it.
For the suspend vs execute - wouldn't the pipeline stop executing, because of the "suspend"?

kedro_snowflake/generator.py Outdated Show resolved Hide resolved
kedro_snowflake/generator.py Outdated Show resolved Hide resolved
@mwiewior mwiewior force-pushed the feature/mlflow-support branch 2 times, most recently from 7a4c2d1 to 6daf8d2 Compare June 7, 2023 18:10
docs/source/06_mlflow.md Outdated Show resolved Hide resolved
## Deployment to Snowflake and inference

### Deployment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

kedro_snowflake/generator.py Outdated Show resolved Hide resolved
log_parameter(k, v)


def log_model(model: RandomForestRegressor, X_train: pd.DataFrame, y_train: pd.Series):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover?

kedro_snowflake/generator.py Show resolved Hide resolved
Copy link
Contributor

@Lasica Lasica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

65.7% 65.7% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Lasica Lasica merged commit 5aab95f into develop Jun 20, 2023
8 of 9 checks passed
@Lasica Lasica deleted the feature/mlflow-support branch June 20, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants