Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init MLflow support #2
Init MLflow support #2
Changes from 19 commits
3c62ef5
a22d632
2d0d397
150a48d
54f5b60
6e91f0f
b5c3947
5d65a8b
7435c6e
9480fe1
7349e15
c880eb5
83dcd45
6daf8d2
115a60d
5d64d40
94647ca
acccc84
7dc2061
57abf33
85eea44
d81b84d
013522f
2c31cc3
ddc021b
f70bc4b
062273e
efec3dc
f223c07
99674ae
d44034c
637c73a
9d0a63b
5ec874d
b506515
587b848
84335f7
9d990f9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just add link to https://github.com/Snowflake-Labs/mlflow-snowflake ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-use
self.TASK_TEMPLATE
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be immediately execute
suspend
afterexecute
? Will it work?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not ? For a brand new pipeline it is always suspended - so does not take any effect - for a replaced one it should just change the state ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe it would make sense to always drop a whole pipeline and then recreate it from scratch - it would then fix #3 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be, let's discuss it.
For the
suspend
vsexecute
- wouldn't the pipeline stop executing, because of the "suspend"?