Migrate to Sentry JavaScript V8 #675

lucas-zimerman · 2024-06-17T18:28:25Z

This is a major break change PR for supporting Sentry Javascript V8, for the moment the largest changes are:

To Sentry users:

Drop support for Angular 13
Users using the package @sentry/angular-ivy will have to replace it by @sentry/angular.
Break changes on how to start a Span.
Sentry integrations have changed the way the are loaded.

  new Sentry.Replay(...) -> Sentry.replayIntegration(...)
  new Sentry.BrowserTracing(...) -> browserTracingIntegration(...)

Hud no longer exists, instead, use getClient()
Removed all deprecated functions:

addGlobalEventProcessor,
configureScope,
  getCurrentScope,
  getHubFromCarrier,
  getCurrentHub,
  Hub,
startTransaction,

removed enableOutOfMemoryTracking (replaced by enableWatchdogTerminationTracking)
For a complete list of changes on the JavaScript side, please check the following documentation: https://github.com/getsentry/sentry-javascript/blob/develop/MIGRATION.md#upgrading-from-7x-to-8x

Internally:

Scope no longer exist and we use ScopeSync in order to communicate with the native layer (Based on fix(scope): Hooks into Global and Isolations Scopes for Sync with the native scope sentry-react-native#3911)
Replaced the old method of referring to the SentryCapacitor native plugin with a more modern one (see src/plugin.ts)
Changed the sibling check code to avoid conflicts with the usage of specific words that could be already used by node.

TODO:

Update Samples. Prepare Samples for Sentry Javascript V8 #686
Update Changelog.
Create migration documentation on the repository.
Close Angular 18 Support. #671 Remove @sentry/hub @sentry/tracing #511 Sentry.replayIntegration is not a function #685

…uide

CHANGELOG.md

MIGRATION.md

package.json

src/index.ts

src/sdk.ts

src/integrations/devicecontext.ts

src/integrations/rewriteframes.ts

src/options.ts

src/plugin.ts

test/sdk.test.ts

test/testutils.ts

krystofwoldrich · 2024-07-08T15:10:25Z

Thank you for the massive upgrade to JS V8!

Overall it looks great. I left a few comments which we should resolve before we can merge this.

Co-authored-by: Krystof Woldrich <[email protected]>

…changes. removed setup from integrations. Added check for TextEncoder.

src/integrations/default.ts

CHANGELOG.md

krystofwoldrich · 2024-07-12T11:43:35Z

One more comment remains. The integrations. After that I'll it should be good.

test/sdk.test.ts

krystofwoldrich · 2024-07-31T12:28:43Z

I added a small comment to the test, but it's not blocking.

krystofwoldrich · 2024-07-31T12:28:59Z

Looks good, thank you! 🚀

* apply break changes to code, update yarn from v6 * port sample v6 * bump v5 * bump v4 * bump v3 * bump vue * ios test * expose registerSpanErrorInstrumentation and add changelog/migration guide * Apply suggestions from code review Co-authored-by: Krystof Woldrich <[email protected]> * removed testutils.ts, migration.md, altered changelog with requested changes. removed setup from integrations. Added check for TextEncoder. * forgot to add textEncoders.ts * ordering issue * add back isolationscope * requested changes * yarn fix * requested changes --------- Co-authored-by: Krystof Woldrich <[email protected]>

lucas-zimerman added 15 commits June 17, 2024 15:27

migrate V8 initial commit

2c7cf36

add polyfill, changed integrations structure

ad81a4a

format prettier and update prettier

8fb8140

remove enable out of memory and update packages

27f8e6a

update jest, replace scope with scopeSync

ed0823e

fix deprecated expect tests

e986e2c

fix test build rule

743c4d2

fix default integrations init. Fix SDK tests

41df7db

fix sdkinfo tests

669cff8

fix release tests

9841962

fix native options, rewrite frames and webview tests

6ee9981

lint

2903ee4

isolate race condition

cc803b7

nit build errors

d71ec83

expose registerSpanErrorInstrumentation and add changelog/migration g…

6d07c22

…uide

lucas-zimerman marked this pull request as ready for review July 4, 2024 13:40

lucas-zimerman requested a review from krystofwoldrich July 4, 2024 13:40

lucas-zimerman added the Breaking-change should go in a major release (breaks apps, changes default configs in a major way) label Jul 4, 2024