Prepare Samples for Sentry Javascript V8 #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-zimerman
changed the title
3 tasks
Co-authored-by: Krystof Woldrich <[email protected]>
…changes. removed setup from integrations. Added check for TextEncoder.
| Sentry.configureScope(scope => { | ||
| scope.clearBreadcrumbs(); | ||
| }); | ||
| Sentry.getGlobalScope().clearBreadcrumbs(); |
There was a problem hiding this comment.
H: To keep the same behavior as in v7 we need to clear all the scopes. The global Sentry.addBreadcrumb uses isolationScope
Suggested change
| Sentry.getGlobalScope().clearBreadcrumbs(); | |
| Sentry.getGlobalScope().clearBreadcrumbs(); | |
| Sentry.getIsolationScope().clearBreadcrumbs(); | |
| Sentry.getCurrentScope().clearBreadcrumbs(); |
There was a problem hiding this comment.
I believe that was the code generated by the migration tool.
Ideally we should expose clearBreadcrumbs on the SDK and then it clears on all 3 scopes, what do you think?
|
This PR needs a rebase/merge of #675, to remove the duplicate changes, already done in the predecessor PR. |
krystofwoldrich
approved these changes
Jul 12, 2024
lucas-zimerman
added a commit
that referenced
this pull request
Jul 31, 2024
* migrate V8 initial commit * add polyfill, changed integrations structure * format prettier and update prettier * remove enable out of memory and update packages * update jest, replace scope with scopeSync * fix deprecated expect tests * fix test build rule * fix default integrations init. Fix SDK tests * fix sdkinfo tests * fix release tests * fix native options, rewrite frames and webview tests * lint * isolate race condition * nit build errors * expose registerSpanErrorInstrumentation and add changelog/migration guide * Apply suggestions from code review Co-authored-by: Krystof Woldrich <[email protected]> * removed testutils.ts, migration.md, altered changelog with requested changes. removed setup from integrations. Added check for TextEncoder. * forgot to add textEncoders.ts * ordering issue * add back isolationscope * requested changes * add missing get scope * yarn fix * Prepare Samples for Sentry Javascript V8 (#686) * apply break changes to code, update yarn from v6 * port sample v6 * bump v5 * bump v4 * bump v3 * bump vue * ios test * expose registerSpanErrorInstrumentation and add changelog/migration guide * Apply suggestions from code review Co-authored-by: Krystof Woldrich <[email protected]> * removed testutils.ts, migration.md, altered changelog with requested changes. removed setup from integrations. Added check for TextEncoder. * forgot to add textEncoders.ts * ordering issue * add back isolationscope * requested changes * yarn fix * requested changes --------- Co-authored-by: Krystof Woldrich <[email protected]> * requested changes * test download artifact v4 --------- Co-authored-by: Krystof Woldrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a separated PR so that the main PR wouldn't be too hard to review.
In this PR i bump all samples with Sentry Javascript V8 and validated each of them.
This PR will only contain changes on the samples, mainly upgrading Angular since version 13 is no longer supported, updating ionic/angular due to a bug with the old version, and replaced some Sentry functions to use the new naming scheme.
#skip-changelog