Skip to content

Conversation

@s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Aug 13, 2024

DESCRIBE YOUR PR

There is no hub anymore in JS, only clients.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 8:27am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 8:27am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 8:27am

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@codecov
Copy link

codecov bot commented Aug 14, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes ⬇️

Bundle name Size Change
sentry-docs-server 8.24MB 6 bytes ⬇️
sentry-docs-edge-server 254.16kB 3 bytes ⬇️
sentry-docs-client 6.25MB 6 bytes ⬇️

@s1gr1d s1gr1d merged commit 9a7547f into master Aug 14, 2024
@s1gr1d s1gr1d deleted the sig/hub-scope-renaming branch August 14, 2024 16:02
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants