Skip to content

fix(js): Delete hub occurrences #11068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2024
Merged

fix(js): Delete hub occurrences #11068

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
224fad5
fix(js): Delete hub occurrences
s1gr1d Aug 13, 2024
a41f0e3
Apply suggestions from code review
s1gr1d Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/platforms/javascript/common/best-practices/multiple-sentry-instances.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,11 @@ client.init(); // initializing has to be done after setting the client on the sc
scope.captureException(new Error("example"));
```

You can now customize the scope to your liking, without affecting other hubs/clients.
You can now customize the scope to your liking, without affecting other clients.

### Dealing with Integrations

Integrations are setup on the `Client`, if you need to deal with multiple clients and hubs you have to make sure to also do the integration handling correctly.
Integrations are set up on the `Client`. If you need to deal with multiple clients, you'll have to make sure the integration handling is set up correctly.

We do not recommend doing this if you are using Sentry in a browser extension or in similar scenarios.
If you can't avoid using global integrations (e.g. in a micro frontend application), here is a working example of how to use multiple clients with multiple scopes running global integrations.
Expand All @@ -91,7 +91,7 @@ function happyIntegration() {
setupOnce() {
Sentry.addEventProcessor((event) => {
const self = Sentry.getClient().getIntegration(HappyIntegration);
// Run the integration ONLY when it was installed on the current Hub
// Run the integration ONLY if it was installed on the current client
if (self) {
event.message = `\\o/ ${event.message} \\o/`;
}
Expand Down
Loading