Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect Vue component names in trackComponents #11167

Closed

Conversation

filips123
Copy link

DESCRIBE YOUR PR

This PR fixes the documentation of trackComponents in Vue integration by surrounding component names with <>. I've added this based on discussion in getsentry/sentry-javascript#13484.

Alternatively, sentry-javascript's Vue integration could be modified to allow matching both components surrounded with <> and without.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Aug 28, 2024

@filips123 is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@filips123
Copy link
Author

This PR can probably be closed as it has been decided to change the behaviour of sentry-javascript to match components both with and without <> (getsentry/sentry-javascript#13484, getsentry/sentry-javascript#13510). I'll still keep it open in case you decide to temporarily merge it until this change is implemented.

@Lms24
Copy link
Member

Lms24 commented Aug 28, 2024

Thanks a lot for opening the PR @filips123 but I think we'll close it immediately, given that I'm planning on fixing this soon.

@Lms24 Lms24 closed this Aug 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants