Expired sessions are not being recreated correctly leading to very long session durations #8400
Assignees
Comments
|
relates to: #8257 |
billyvg
changed the title
billyvg
changed the title
|
@mydea Still happening with 7.59 beta |
|
This is hopefully addressed with: #8596, right? |
|
@bruno-garcia It's still happening, we have a follow-up PR here #8617 |
|
#8617 released on 7.61.0 |
|
Seems to still be happening, e.g. https://sentry.sentry.io/replays/2ae431858a0f4fa3b88d10bfa1ac54a1/?project=11276&query=sdk.version%3A7.60.1&referrer=%2Freplays%2F&statsPeriod=4d&yAxis=count%28%29 here we have a few logs that may help debugging this. |
|
Issue is still apparent |
This was referenced Aug 2, 2023
mydea
added a commit
that referenced
this issue
Aug 3, 2023
This streamlines & improves logging for replay status, adding more logs for certain things to be better able to see what's going on, and adapting the `traceInternals` setting to result in console breadcrumbs being added (which should show up both in replay and for e.g. sentry errors etc). While at it I also fixed some `any` eslint warnings in replay. ref: #8400
mydea
added a commit
that referenced
this issue
Aug 3, 2023
We haven't been persisting the `shouldRefresh` property of the session. This combined with the fact that we do not update the `sampled` field on the session to `session` when an error occurs, but keep it at `buffer`, means that if a user reloads the page or the session is otherwise re-fetched from sessionStorage, if previously an error occurs, we'll keep buffering forever again (like for a "fresh" buffer session), and if an error happens we convert it again to a `session` session, but since the session ID was never updated this will be "added" to the previous session instead. I made a reproduction test that failed before and works after this fix. Fixes #8400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expired sessions are not correctly creating a new session, likely a regression due to #8258 (though this affects both buffered and session replays).
Take a look at Sentry's replays for an example (sort by duration desc).
The text was updated successfully, but these errors were encountered: