Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(browser): Remove webpack build tests #12967

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Jul 18, 2024

Removes packages/browser/test/package/npm-build.js. This also means we can drop the webpack dev dep in the browser sdk package. Combining dropping webpack with upgrading fake-indexeddb to 6.0.0 means we can reduce the yarn.lock file by 1185 lines! Edit: I couldn't upgrade fake-indexeddb because of a jest/jsdom bug, will tackle it when we vitest this package!

packages/browser/test/package/npm-build.js contained three tests:

  1. Test against tslib_1__default appearing in the bundle. I added a browser integration test to replicate this
  2. Test that adding a bundled package would work, our integration + e2e tests pretty much cover this
  3. Test that you can add bundle packages multiple times - our integration + e2e tests also cover this

I also migrated packages/utils/test/types/index.js to use jest instead of a plain script.

@AbhiPrasad AbhiPrasad requested a review from a team July 18, 2024 00:55
@AbhiPrasad AbhiPrasad self-assigned this Jul 18, 2024
@AbhiPrasad AbhiPrasad requested review from lforst and Lms24 and removed request for a team July 18, 2024 00:55
@AbhiPrasad AbhiPrasad force-pushed the abhi-remove-old-build-test branch 2 times, most recently from 5bf6015 to 6aadd3a Compare July 18, 2024 01:34
@AbhiPrasad AbhiPrasad changed the title test(browser): Remove unused webpack build tests test(browser): Remove webpack build tests Jul 18, 2024
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Agree, all of this is covered by e2e and intregration tests. Goes to show how much better our testing capabilities have become in the last 2 years.

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) July 18, 2024 18:10
@AbhiPrasad AbhiPrasad merged commit 789231c into develop Jul 18, 2024
123 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-remove-old-build-test branch July 18, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants