Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add some additional GH project automation #13608

Closed
wants to merge 15 commits into from

Conversation

mydea
Copy link
Member

@mydea mydea commented Sep 6, 2024

This automation makes some tweaks to our GH Project:

  1. When a PR is opened in draft mode, move to "In Progress" on the board
  2. When a PR is opened for review, move to "In Review" on the board
  3. When a PR is closed but not merged, move it directly to "Done" (instead of "Ready for Release")

@mydea mydea self-assigned this Sep 6, 2024
@mydea mydea marked this pull request as ready for review September 6, 2024 10:10
@mydea mydea marked this pull request as draft September 6, 2024 10:12
@mydea mydea marked this pull request as ready for review September 6, 2024 10:12
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mydea mydea marked this pull request as draft September 6, 2024 11:51
@mydea mydea marked this pull request as ready for review September 6, 2024 11:51
@mydea mydea marked this pull request as draft September 6, 2024 12:00
@mydea mydea marked this pull request as ready for review September 6, 2024 12:00
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Generally no objections but does this lead to scenarios where we have duplicated entries for the issue as well as the PR or can we somehow filter out PRs that auto-close issues?

@mydea mydea marked this pull request as draft September 6, 2024 12:02
@mydea mydea marked this pull request as ready for review September 6, 2024 12:03
@mydea mydea marked this pull request as draft September 6, 2024 12:06
@mydea mydea marked this pull request as ready for review September 6, 2024 12:07
@mydea
Copy link
Member Author

mydea commented Sep 6, 2024

This seems to be failing 😬 see github/update-project-action#170

Not sure if I am doing something wrong...

@Lms24 it should only update the status. Need to test it if it is not in the project at all, but should not add to it! (I switched actions while playing around with this - this is not super easy because of beta and classic projects 😬 )

@mydea mydea marked this pull request as draft September 9, 2024 07:23
@mydea mydea marked this pull request as ready for review September 9, 2024 07:23
@mydea
Copy link
Member Author

mydea commented Sep 9, 2024

Sadly, this does not seem to work. The reason is the SSO requirements etc. we have for getsentry access 😬 can't get my tokens to play nice with this. I may revisit this later!

@mydea mydea closed this Sep 9, 2024
@mydea mydea reopened this Sep 9, 2024
@mydea mydea marked this pull request as draft September 9, 2024 11:17
@mydea mydea marked this pull request as ready for review September 9, 2024 11:17
@mydea mydea marked this pull request as draft September 9, 2024 11:20
@mydea mydea marked this pull request as ready for review September 9, 2024 11:20
@mydea mydea closed this Sep 9, 2024
@mydea mydea reopened this Sep 9, 2024
@mydea mydea marked this pull request as draft September 9, 2024 11:21
@mydea mydea marked this pull request as ready for review September 9, 2024 11:32
@mydea mydea marked this pull request as draft September 9, 2024 11:35
@mydea mydea marked this pull request as ready for review September 9, 2024 11:38
@mydea mydea marked this pull request as draft September 9, 2024 11:39
@mydea mydea marked this pull request as ready for review September 9, 2024 11:41
@mydea mydea closed this Sep 9, 2024
mydea added a commit that referenced this pull request Sep 10, 2024
Follow up to #13608,
after some tweaks and a rebase!

* When a PR is opened in draft mode, move to "In Progress" on the board
* When a PR is opened for review, move to "In Review" on the board
* When a PR is closed but not merged, move it directly to "Done"
(instead of "Ready for Release")

Note that for now, this only applies to PRs that are on the board
themselves, not to PRs linked to an issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants