test(nuxt): Add tests for Vue component tracking #13633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Sep 9, 2024
| await page.goto(`/client-error`); | ||
|
|
||
| const rootSpan = await transactionPromise; | ||
| const errorButtonSpan = rootSpan.spans.find((span: Span) => span.description === 'Vue <<ErrorButton>>'); |
There was a problem hiding this comment.
heads-up: After merging https://github.com/getsentry/sentry-javascript/pull/13543/files, the component name should only be wrapped with <Name> and not <<Name>> anymore. Probably best to rebase to latest develop and double-check.
s1gr1d
force-pushed
the
sig/nuxt-track-components
branch
from
c3f87be
to
6b44ea0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.