-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add plugin support #230
Conversation
@romtsn I haven't added any tests, just wanted to see what you think about the current state of this draft, the important files I'd say are the rest hasn't really been polished or anything yet |
also tbd: auto installing the kmp dependency in commonMain |
...ry-samples/kmp-app-cocoapods/iosApp/iosApp.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
==========================================
- Coverage 78.52% 75.43% -3.09%
==========================================
Files 31 38 +7
Lines 419 574 +155
Branches 56 85 +29
==========================================
+ Hits 329 433 +104
- Misses 64 96 +32
- Partials 26 45 +19 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go, great work!
just gonna add a couple more tests. should we do an alpha or beta first? |
yeah, I think a beta is reasonable, maybe ping people on the issues that were reported to try this out as well. Or add to the docs, like a banner or whatever |
📜 Description
Adds plugin for easier installation process
💡 Motivation and Context
Fixes #108 and #191
💚 How did you test it?
Unit tests, samples
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps