Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add plugin support #230

Merged
merged 82 commits into from
Aug 5, 2024
Merged

feat: add plugin support #230

merged 82 commits into from
Aug 5, 2024

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Jun 5, 2024

📜 Description

Adds plugin for easier installation process

💡 Motivation and Context

Fixes #108 and #191

💚 How did you test it?

Unit tests, samples

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.

🔮 Next steps

@buenaflor
Copy link
Contributor Author

@romtsn I haven't added any tests, just wanted to see what you think about the current state of this draft, the important files I'd say are LinkerExtension.kt, SentryExtension.kt and SentryPlugin.kt

the rest hasn't really been polished or anything yet

@buenaflor
Copy link
Contributor Author

also tbd: auto installing the kmp dependency in commonMain

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 67.09677% with 51 lines in your changes missing coverage. Please review.

Project coverage is 75.43%. Comparing base (91222ef) to head (5720a9a).

Files Patch % Lines
...sentry/kotlin/multiplatform/gradle/SentryPlugin.kt 54.95% 32 Missing and 18 partials ⚠️
...multiplatform/gradle/DerivedDataPathValueSource.kt 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   78.52%   75.43%   -3.09%     
==========================================
  Files          31       38       +7     
  Lines         419      574     +155     
  Branches       56       85      +29     
==========================================
+ Hits          329      433     +104     
- Misses         64       96      +32     
- Partials       26       45      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go, great work!

@buenaflor buenaflor marked this pull request as ready for review August 1, 2024 18:06
@buenaflor
Copy link
Contributor Author

@romtsn

just gonna add a couple more tests.

should we do an alpha or beta first?

@romtsn
Copy link
Member

romtsn commented Aug 1, 2024

@romtsn

just gonna add a couple more tests.

should we do an alpha or beta first?

yeah, I think a beta is reasonable, maybe ping people on the issues that were reported to try this out as well. Or add to the docs, like a banner or whatever

@buenaflor buenaflor enabled auto-merge (squash) August 5, 2024 12:59
@buenaflor buenaflor merged commit 17a7519 into main Aug 5, 2024
16 of 18 checks passed
@buenaflor buenaflor deleted the feat/add-plugin branch August 5, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Gradle Plugin] Add support for creating a dynamic library when using SPM and Cocoapods (not kotlin cocoapods)
3 participants